Skip to content

AmbiguityCause should not eagerly format strings #118267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2023
Merged

AmbiguityCause should not eagerly format strings #118267

merged 1 commit into from
Nov 26, 2023
+54 −67

Conversation

compiler-errors
Copy link
Member

Minor tweak found when working on some coherence diagnostics stuff (towards -Ztrait-solver=next-coherence stabilization)

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2023

r? @spastorino

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@spastorino
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 25, 2023

📌 Commit 0750a5d has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
@bors
Copy link
Collaborator

bors commented Nov 26, 2023

⌛ Testing commit 0750a5d with merge 0b8a61b...

@bors
Copy link
Collaborator

bors commented Nov 26, 2023

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 0b8a61b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 26, 2023
@bors bors merged commit 0b8a61b into rust-lang:master Nov 26, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 26, 2023
@bors bors mentioned this pull request Nov 26, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0b8a61b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.8%, -0.2%] 5
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-0.8%, -0.2%] 5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)		 3.9% [3.2%, 4.6%] 3
Improvements ✅
(primary)		 -1.4% [-1.5%, -1.2%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.3% [-1.5%, 3.5%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.5%, 2.6%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.058s -> 674.277s (-0.12%)
Artifact size: 313.35 MiB -> 313.37 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @rust-log-analyzer @spastorino @bors @rust-timer